Skip to content

Add 7-day average of each signal to Safegraph indicator #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 170 commits into from
Oct 20, 2020
Merged

Add 7-day average of each signal to Safegraph indicator #309

merged 170 commits into from
Oct 20, 2020

Conversation

sgsmob
Copy link
Contributor

@sgsmob sgsmob commented Oct 13, 2020

Fixes #271.

For each signal at a geo resolution output as part of the delphi_safegraph module, create another version of the signal that is averaged over the previous 7 days.

Also cleans up test and comments.

Jingjing Tang and others added 30 commits August 24, 2020 16:02
try until pull the new data successfully
b566d4c
used tenacity
8db2799
@vishakha1812
Add .gitignore
c9b16a5
@vishakha1812
Update params.json.template
f969d96
@vishakha1812
Update run.py
56db650
@vishakha1812
Update setup.py
775efe1
@vishakha1812
Update test_update_sensor.py
df20f05
@vishakha1812
Update update_sensor.py
9295eac
@vishakha1812
Add constants.py
786cef4
@vishakha1812
Add static files
3391ff3
@vishakha1812
Minor changes
40091b7
@vishakha1812
removed wildcard import error
db54eb8
@vishakha1812
update params.json.template
2a9a68f
@vishakha1812
Add wip_signal key in ansible
319f038
@vishakha1812
Add missing receiving directory
17fb5ae
@krivard
Merge pull request cmu-delphi#239 from cmu-delphi/main
8a40c1c 
Merge main into deploy-google_health
@vishakha1812
Merge branch 'deploy-google_health' into fix_ght_pulling
dd4085b
Add requirement tenacity
65490cc
fixed invalid character
d4b6f69
add code
a24dc4d
fixed an error in unit tests
e833515
removed unused files
5f7ffa1
changed format of intermediate output dataframes
870fd20
@jingjtang
uncommented code for pulling raw data
b9a788f
Added code for using geomap utils
ad1d4d5
@vishakha1812
Minor changes
130a9a7
@vishakha1812
Minor change in update_sensor.py
b450f42
@vishakha1812
Update test_update_sensor.py
a6e07b8
@krivard
Merge pull request cmu-delphi#250 from cmu-delphi/wip_emr
008bd9b 
EMR: standard signal names
@krivard
Merge pull request cmu-delphi#247 from cmu-delphi/fix_ght_pulling
3553e00 
[GHT] try until pull the new data successfully
@sgsmob sgsmob requested a review from benjaminysmith October 16, 2020 17:39
benjaminysmith
benjaminysmith previously approved these changes Oct 19, 2020
View reviewed changes
@krivard
Copy link
Contributor

krivard commented Oct 19, 2020

What are the signal names for the 7-day average outputs? I'll need to add them to the wip list before we can merge.

@sgsmob
Copy link
Contributor Author

sgsmob commented Oct 19, 2020

Ah, I have not actually written them to different files. Let me get on that and get back to you

korlaxxalrok
korlaxxalrok previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sgsmob
Copy link
Contributor Author

sgsmob commented Oct 19, 2020 •
edited
Loading

@krivard Smoothed signals are named {signal}_7d_avg. They have been added the appropriate field in the params.json file. PTAL

@krivard krivard changed the base branch from main to deploy-safegraph October 20, 2020 13:29
@krivard krivard dismissed stale reviews from korlaxxalrok and benjaminysmith October 20, 2020 13:29

The base branch was changed.

@krivard krivard merged commit ee49484 into cmu-delphi:deploy-safegraph Oct 20, 2020
This was referenced Oct 20, 2020
Merged
Closed
Merged
Closed
@sgsmob sgsmob mentioned this pull request Oct 20, 2020
Merged
@krivard krivard mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@korlaxxalrok korlaxxalrok korlaxxalrok left review comments

+2 more reviewers

@krivard krivard krivard approved these changes

@benjaminysmith benjaminysmith benjaminysmith left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 7-day average versions of SafeGraph signals